-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/override console with logger #2331
Merged
filrak
merged 13 commits into
vuestorefront:develop
from
bitbull-team:feature/override-console-with-logger
Feb 4, 2019
Merged
WIP: Feature/override console with logger #2331
filrak
merged 13 commits into
vuestorefront:develop
from
bitbull-team:feature/override-console-with-logger
Feb 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see if the console context is kept |
filrak
changed the title
Feature/override console with logger
WIP: Feature/override console with logger
Feb 1, 2019
pkarw
approved these changes
Feb 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me. @filrak please give us the final green light to merge this one in
Looks good to me too. Finally we have everything covered. Thank you! |
filrak
approved these changes
Feb 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#2235
Short description and why it's useful
Replace console with a custom Logger class, in order to enhance control of logging. All console configurations can be made from the configuration file under
console
key.the
verbosityLevel
key will be used for level switch, available values are:display-everything
display debug,info,warn and erroronly-errors
display only error messagesno-console
disable all messagesAdditionally when you set
NODE_ENV
environment variable to "production" every message will be automatically disabled. You can override this behavior only for error messages settingshowErrorOnProduction
to "true".Screenshots of visual changes before/after (if there are any)
Upgrade Notes and Changelog
Contribution and currently important rules acceptance